It's asking but need to tweek setting values from registers

inc/hoymiles/port.h

@@ -6,59 +6,11 @@
 #include <vector>
 #include <memory>
 
+#include "portParametersGeneric.h"
+
 struct _modbus;
 typedef _modbus modbus_t;
 
-class PortParameter {
-      protected:
-	uint16_t parameterAddressOffset;
-	int registerSize;
-
-	virtual void setValueFromRegisters(uint16_t *readArray, int registerCount);
-
-      public:
-	PortParameter(std::string name, uint16_t parameterAddressOffset, int registerSize);
-
-	virtual ~PortParameter();
-
-	enum PortParameterValueType { Int, Float };
-
-	union PortParameterValue {
-		int i;
-		float f;
-	};
-
-      protected:
-    PortParameterValueType valueType;
-	PortParameterValue value;
-
-      public:
-	std::string name;
-
-	std::pair<PortParameterValue, PortParameterValueType> getValue();
-
-	virtual std::string getOutputValue();
-
-	void updateValue(modbus_t *modbus_context, uint16_t portStartAddress);
-};
-
-class PortParameterFloat : public PortParameter {
-      protected:
-    int decimalPlaces;
-
-    void setValueFromRegisters(uint16_t *readArray, int registerCount);
-
-	  public:
-	PortParameterFloat(std::string name, int decimalPlaces, uint16_t parameterAddressOffset, int registerSize);
-
-	virtual std::string getOutputValue();
-};
-
-class PortParameterInt : public PortParameter {
-	  protected:
-	void setValueFromRegisters()
-};
-
 class Port {
       private:
 	modbus_t *modbus_context;

inc/hoymiles/portParameters/portParameters.h

@@ -0,0 +1,84 @@
+#ifndef PORTPARAMETERS_H
+#define PORTPARAMETERS_H
+
+#include "portParametersGeneric.h"
+
+class PortParameterMicroinverterSerialNumber : public PortParameterInt {
+      public:
+    PortParameterMicroinverterSerialNumber();
+};
+
+class PortParameterPortNumber : public PortParameterInt {
+      private:
+    void setValueFromRegisters(uint16_t *readArray, int registerCount);
+
+      public:
+    PortParameterPortNumber();
+};
+
+class PortParameterPvVoltage : public PortParameterFloat {
+      public:
+    PortParameterPvVoltage();
+};
+
+class PortParameterPvCurrentMi : public PortParameterFloat {
+      public:
+    PortParameterPvCurrentMi();
+};
+
+class PortParameterPvCurrentHm : public PortParameterFloat {
+      public:
+    PortParameterPvCurrentHm();
+};
+
+class PortParameterGridVoltage : public PortParameterFloat {
+      public:
+    PortParameterGridVoltage();
+};
+
+class PortParameterGridFrequency : public PortParameterFloat {
+      public:
+    PortParameterGridFrequency();
+};
+
+class PortParameterPvPower : public PortParameterFloat {
+      public:
+    PortParameterPvPower();
+};
+
+class PortParameterTodayProduction : public PortParameterInt {
+      public:
+    PortParameterTodayProduction();
+};
+
+class PortParameterTotalProduction : public PortParameterInt {
+      public:
+    PortParameterTotalProduction();
+};
+
+class PortParameterTemperature : public PortParameterFloat {
+      public:
+    PortParameterTemperature();
+};
+
+class PortParameterOperatingStatus : public PortParameterInt {
+      public:
+    PortParameterOperatingStatus();
+};
+
+class PortParameterAlarmCode : public PortParameterInt {
+      public:
+    PortParameterAlarmCode();
+};
+
+class PortParameterAlarmCount : public PortParameterInt {
+      public:
+    PortParameterAlarmCount();
+};
+
+class PortParameterLinkStatus : public PortParameterInt {
+      public:
+    PortParameterLinkStatus();
+};
+
+#endif

inc/hoymiles/portParameters/portParametersGeneric.h

@@ -0,0 +1,66 @@
+#ifndef PORTPARAMETERSGENERIC_H
+#define PORTPARAMETERSGENERIC_H
+
+#include <stdint.h>
+#include <string>
+
+struct _modbus;
+typedef _modbus modbus_t;
+
+class PortParameter {
+      protected:
+	uint16_t parameterAddressOffset;
+	int registerSize;
+
+	virtual void setValueFromRegisters(uint16_t *readArray, int registerCount);
+
+      public:
+	PortParameter(std::string name, uint16_t parameterAddressOffset, int registerSize);
+
+	virtual ~PortParameter();
+
+	enum PortParameterValueType { Int, Float };
+
+	union PortParameterValue {
+		long i;
+		float f;
+	};
+
+      protected:
+    PortParameterValueType valueType;
+	PortParameterValue value;
+
+      public:
+	std::string name;
+	int age;
+
+	std::pair<PortParameterValue, PortParameterValueType> getValue();
+
+	virtual std::string getOutputValue();
+
+	void updateValue(modbus_t *modbus_context, uint16_t portStartAddress);
+};
+
+class PortParameterFloat : virtual public PortParameter {
+      protected:
+    int decimalPlaces;
+
+    virtual void setValueFromRegisters(uint16_t *readArray, int registerCount);
+
+	  public:
+	PortParameterFloat(std::string name, int decimalPlaces, uint16_t parameterAddressOffset, int registerSize);
+
+	std::string getOutputValue();
+};
+
+class PortParameterInt : virtual public PortParameter {
+	  protected:
+	virtual void setValueFromRegisters(uint16_t *readArray, int registerCount);
+
+	  public:
+	PortParameterInt(std::string name, uint16_t parameterAddressOffset, int registerSize);
+
+	std::string getOutputValue();
+};
+
+#endif